Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1174763002: Use ConstantVerifier in VerifyUnitTask. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use ConstantVerifier in VerifyUnitTask. Number of failing tests: 126 -> 30. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c5c4d5e788c497a35c81bedf56b6003b903a35be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-09 21:29:48 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-09 21:32:10 UTC) #2
scheglov
5 years, 6 months ago (2015-06-09 22:26:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5c4d5e788c497a35c81bedf56b6003b903a35be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698