Process handled exports correctly.

Process handled exports correctly.

This should solve the resolution bug in http://dartbug.com/7069

Committed: https://code.google.com/p/dart/source/detail?r=17211

[ahe, 2013-01-03 15:08:48]

I don't see a test.

[Johnni Winther, 2013-01-04 07:52:23]

A white box test is added.

[ahe, 2013-01-04 08:46:35]

Thank you for adding a test. Not only is it important to test changes, but it
also helps me understand the problem/changes better.

I'm not sure I understand why this works. If I understand it correctly, this
solution relies on the fact that dart:core doesn't reexport anything.  I'll be
in the office soon, so lets talk in person.

https://codereview.chromium.org/11747010/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/library_loader.dart (right):

https://codereview.chromium.org/11747010/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/library_loader.dart:535:
assert(invariant(library, exportedLibraryElement.exportsHandled));
This invariant is not using the correct location. It should be the value of
exportNode where registerHandledExports is called. However, that's probably also
broken as the compiler doesn't have a current element at this point.

I'm not really sure what this means.

[Johnni Winther, 2013-01-07 09:07:17]

PTAL

Unittest added.

[Johnni Winther, 2013-01-10 10:26:41]

Ping

[ahe, 2013-01-16 17:52:59]

LGTM!

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
File tests/compiler/dart2js/reexport_handled_test.dart (right):

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:9: import
'../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart';
Could you "show" what is imported here?

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:9: import
'../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart';
Also, add this:

import
'../../../sdk/lib/_internal/compiler/implementation/elements/elements.dart'
    show LibraryElement,
         Element;

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:11: var exportingLibraryUri =
new Uri('exporting.dart');
var -> final.

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:12: var exportingLibrarySource
= '''
For consistency with other tests, use:

const String EXPORTING_LIBRARY_SOURCE = ...

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:17: var reexportingLibraryUri
= new Uri('reexporting.dart');
var -> final.

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:18: var
reexportingLibrarySource = '''
const HACKER_STYLE

[Johnni Winther, 2013-01-17 14:23:08]

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
File tests/compiler/dart2js/reexport_handled_test.dart (right):

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:9: import
'../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart';
On 2013/01/16 17:52:59, ahe wrote:
> Could you "show" what is imported here?

Nothing apparantly. Removed.

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:9: import
'../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart';
On 2013/01/16 17:52:59, ahe wrote:
> Also, add this:
> 
> import
> '../../../sdk/lib/_internal/compiler/implementation/elements/elements.dart'
>     show LibraryElement,
>          Element;

Done.

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:17: var reexportingLibraryUri
= new Uri('reexporting.dart');
On 2013/01/16 17:52:59, ahe wrote:
> var -> final.

Done.

https://codereview.chromium.org/11747010/diff/10001/tests/compiler/dart2js/re...
tests/compiler/dart2js/reexport_handled_test.dart:18: var
reexportingLibrarySource = '''
On 2013/01/16 17:52:59, ahe wrote:
> const HACKER_STYLE

Done.