Issue 1174563003: Fix the test to remove extra hint.

Issue 1174563003: Fix the test to remove extra hint. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix the test to remove extra hint. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d2f80cfaec9ed28afda076023cb77e13db068b21

Patch Set 2 : Respect AnalysisOptions.hint == false. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	pkg/analyzer/test/src/task/dart_test.dart	View	1	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1174563003/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1174563003/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode11478 pkg/analyzer/test/generated/resolver_test.dart:11478: return sum; Why didn't we get the hint ...

5 years, 6 months ago (2015-06-09 16:25:57 UTC) #2

scheglov

PTAL https://codereview.chromium.org/1174563003/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1174563003/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode11478 pkg/analyzer/test/generated/resolver_test.dart:11478: return sum; On 2015/06/09 16:25:57, Brian Wilkerson wrote: ...

5 years, 6 months ago (2015-06-09 17:23:59 UTC) #3

scheglov

5 years, 6 months ago (2015-06-09 17:49:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d2f80cfaec9ed28afda076023cb77e13db068b21 (presubmit successful).

Expand Messages | Collapse Messages