Issue 1174343006: Landing https://codereview.chromium.org/1171223003/ for Chinmay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174343006: Landing https://codereview.chromium.org/1171223003/ for Chinmay. (Closed)

Created:
5 years, 6 months ago by Ivan Posva

Modified:
5 years, 6 months ago

Reviewers:
Chinmay

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -1 line)			Patch
M	runtime/bin/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file_system_watcher_macos.cc	View	2 chunks	+42 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_macos.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Ivan Posva

5 years, 6 months ago (2015-06-13 13:36:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7158d5fc260aa1f28bf900008173ed17598e6f76 (presubmit successful).