Issue 11740025: Add dart2js option to select library categories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11740025: Add dart2js option to select library categories. (Closed)

Created:
7 years, 11 months ago by ahe

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add dart2js option to select library categories. By default, the compiler will only accept the Client category, meaning that it will be an error to import dart:io. During testing on d8, the compiler will support all library categories to continue supporting so called "mock compilation". Committed: https://code.google.com/p/dart/source/detail?r=17637

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix dartdoc and some unit tests #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -6 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart	View	1	4 chunks	+17 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/dart2js.dart	View	1 2	4 chunks	+33 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1 2	3 chunks	+7 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/analyze_api_test.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/dart_backend_test.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

PTAL, I think all tests are passing now, including dart2dart. Also, dartdoc works.

7 years, 11 months ago (2013-01-25 11:08:02 UTC) #3

lgtm

Expand Messages | Collapse Messages