Fix issue 7677: recognize const declarations inside methods.

Fix issue 7677: recognize const declarations inside methods.
Committed: https://code.google.com/p/dart/source/detail?r=17262

[ahe, 2013-01-03 14:09:25]

LGTM!

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:464:
return makeTypeConstant(element);
To ease my mind, could you add this:

} else if (send.receiver != null) {
  // Fall through to error handling.

[ngeoffray, 2013-01-08 14:36:11]

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:464:
return makeTypeConstant(element);
On 2013/01/03 14:09:26, ahe wrote:
> To ease my mind, could you add this:
> 
> } else if (send.receiver != null) {
>   // Fall through to error handling.

This is not easing mine :) Where do you want to put that check? Why does it make
it easier to you?

[ngeoffray, 2013-01-10 13:16:39]

On 2013/01/08 14:36:11, ngeoffray wrote:
>
https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
> File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
> (right):
> 
>
https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
> sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:464:
> return makeTypeConstant(element);
> On 2013/01/03 14:09:26, ahe wrote:
> > To ease my mind, could you add this:
> > 
> > } else if (send.receiver != null) {
> >   // Fall through to error handling.
> 
> This is not easing mine :) Where do you want to put that check? Why does it
make
> it easier to you?

Ping.

[ngeoffray, 2013-01-17 17:51:33]

On 2013/01/10 13:16:39, ngeoffray wrote:
> On 2013/01/08 14:36:11, ngeoffray wrote:
> >
>
https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
> > File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
> > (right):
> > 
> >
>
https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
> > sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:464:
> > return makeTypeConstant(element);
> > On 2013/01/03 14:09:26, ahe wrote:
> > > To ease my mind, could you add this:
> > > 
> > > } else if (send.receiver != null) {
> > >   // Fall through to error handling.
> > 
> > This is not easing mine :) Where do you want to put that check? Why does it
> make
> > it easier to you?
> 
> Ping.

New ping.

[ahe, 2013-01-18 11:07:11]

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:464:
return makeTypeConstant(element);
On 2013/01/08 14:36:11, ngeoffray wrote:
> On 2013/01/03 14:09:26, ahe wrote:
> > To ease my mind, could you add this:
> > 
> > } else if (send.receiver != null) {
> >   // Fall through to error handling.
> 
> This is not easing mine :) Where do you want to put that check?

Right here, before the new code.

> Why does it make it easier to you?

Because I don't want this to become a constant expression by accident:

someConstant.field

[ngeoffray, 2013-01-18 11:15:30]

Thanks Peter.

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/11740019/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:464:
return makeTypeConstant(element);
On 2013/01/18 11:07:11, ahe wrote:
> On 2013/01/08 14:36:11, ngeoffray wrote:
> > On 2013/01/03 14:09:26, ahe wrote:
> > > To ease my mind, could you add this:
> > > 
> > > } else if (send.receiver != null) {
> > >   // Fall through to error handling.
> > 
> > This is not easing mine :) Where do you want to put that check?
> 
> Right here, before the new code.
> 
> > Why does it make it easier to you?
> 
> Because I don't want this to become a constant expression by accident:
> 
> someConstant.field

Done.