Issue 11734032: Add test for issues with cascades.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11734032: Add test for issues with cascades. (Closed)

Created:
7 years, 11 months ago by srdjan

Modified:
7 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, Tom Ball

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add test for issues with cascades. Committed: https://code.google.com/p/dart/source/detail?r=16622

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -0 lines)			Patch
A	tests/language/cascade_2_test.dart	View	1 2	1 chunk	+50 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/11734032/diff/3001/tests/language/cascade_2_test.dart File tests/language/cascade_2_test.dart (right): https://codereview.chromium.org/11734032/diff/3001/tests/language/cascade_2_test.dart#newcode11 tests/language/cascade_2_test.dart:11: Expect.equals(1, a.path2.length); // NPE. It would be ...

7 years, 11 months ago (2013-01-04 01:29:54 UTC) #2

srdjan

7 years, 11 months ago (2013-01-04 01:34:08 UTC) #3

https://codereview.chromium.org/11734032/diff/3001/tests/language/cascade_2_t...
File tests/language/cascade_2_test.dart (right):

https://codereview.chromium.org/11734032/diff/3001/tests/language/cascade_2_t...
tests/language/cascade_2_test.dart:11: Expect.equals(1, a.path2.length);  //
NPE.
On 2013/01/04 01:29:55, Ivan Posva wrote:
> It would be nice if you checked that the result is not just the correct
length,
> but also contains the right values.

Done.

Expand Messages | Collapse Messages

Issue 11734032: Add test for issues with cascades. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages