Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 11733005: Enable a couple of tests that were disabled because they (Closed)

Created:
7 years, 11 months ago by Mads Ager (google)
Modified:
7 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable a couple of tests that were disabled because they did not have a name ending in _test.dart. Deleted a test that tested the arguments to readInto on a socket input stream. readInto is being deprecated and rewriting the test would be a waste of time. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -177 lines) Patch
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/standalone/io/http_headers_state.dart View 1 chunk +0 lines, -73 lines 0 comments Download
A + tests/standalone/io/http_headers_state_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/standalone/io/regress-1925.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/standalone/io/regress-6521.dart View 1 chunk +0 lines, -41 lines 0 comments Download
A + tests/standalone/io/regress_6521_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
7 years, 11 months ago (2013-01-02 14:41:35 UTC) #1
Søren Gjesse
7 years, 11 months ago (2013-01-02 15:06:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698