Issue 11727008: Fix badly written test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11727008: Fix badly written test (Closed)

Created:
7 years, 11 months ago by Søren Gjesse

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix badly written test The test closed the output stream on an HTTP response before consuming the request. R=ager@google.com BUG=dart:7562 Committed: https://code.google.com/p/dart/source/detail?r=16639

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -20 lines)			Patch
	M	tests/standalone/io/http_content_length_test.dart	View		3 chunks	+23 lines, -20 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

7 years, 11 months ago (2013-01-02 13:26:43 UTC) #2

LGTM

https://codereview.chromium.org/11727008/diff/1/tests/standalone/io/http_cont...
File tests/standalone/io/http_content_length_test.dart (right):

https://codereview.chromium.org/11727008/diff/1/tests/standalone/io/http_cont...
tests/standalone/io/http_content_length_test.dart:66: Expect.throws(() =>
response.contentLength = 3, (e) => e is HttpException);
Long line.

Expand Messages | Collapse Messages