Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1172693003: Move computeType to TypedElement and TypeDeclarationElement. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move computeType to TypedElement and TypeDeclarationElement. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/8a0c73cf4c373371dee9ecc136adfc986d3768ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -67 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 4 chunks +20 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 6 chunks +19 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-09 14:22:51 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-06-10 07:08:00 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-11 13:18:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a0c73cf4c373371dee9ecc136adfc986d3768ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698