Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1172623003: Don't hardcode linux as the build os in pub annotated (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
Reviewers:
nweiz, Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't hardcode linux as the build os in pub annotated windows does not like that :-) R=whesse@google.com, nweiz@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dae0c0d6f0234023c4a7238bafdc307860c6c24e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bots/pub.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 6 months ago (2015-06-09 11:44:25 UTC) #1
Bill Hesse
lgtm
5 years, 6 months ago (2015-06-09 12:11:28 UTC) #2
ricow1
5 years, 6 months ago (2015-06-09 12:12:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dae0c0d6f0234023c4a7238bafdc307860c6c24e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698