Issue 1172213002: Improve the capture and display of syntax errors in VM tests.

Issue 1172213002: Improve the capture and display of syntax errors in VM tests. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve the capture and display of syntax errors in VM tests. This captures some syntax errors that were previously falling by the wayside, and cleans up some edge cases in displaying syntax errors in general. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/097b2efe35035a71cf35c02782bd39b6ac033940

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -3 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/runner/load_exception.dart	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	lib/src/runner/vm/isolate_listener.dart	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	test/runner/runner_test.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM, although check the delta on expec_async test https://codereview.chromium.org/1172213002/diff/1/test/frontend/expect_async_test.dart File test/frontend/expect_async_test.dart (left): https://codereview.chromium.org/1172213002/diff/1/test/frontend/expect_async_test.dart#oldcode13 test/frontend/expect_async_test.dart:13: group("supports ...

5 years, 6 months ago (2015-06-10 14:24:11 UTC) #2

nweiz

Committed patchset #2 (id:20001) manually as 097b2efe35035a71cf35c02782bd39b6ac033940 (presubmit successful).

5 years, 6 months ago (2015-06-10 21:21:22 UTC) #4

nweiz

5 years, 6 months ago (2015-06-10 21:22:01 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1172213002/diff/1/test/frontend/expect_async_...
File test/frontend/expect_async_test.dart (left):

https://codereview.chromium.org/1172213002/diff/1/test/frontend/expect_async_...
test/frontend/expect_async_test.dart:13: group("supports a function with this
many arguments:", () {
On 2015/06/10 14:24:10, kevmoo wrote:
> Oops?

Done.

Expand Messages | Collapse Messages