Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 1171783002: Fix broken tests. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix broken tests. These tests broke when removing compatibility with the old "pub run" behavior. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/68308887177ef3b78fdd52f068e4eaefe1b17e07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
D test/run/runs_app_in_entrypoint_with_warning_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
M test/run/runs_the_script_in_checked_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 6 months ago (2015-06-08 21:50:49 UTC) #1
Bob Nystrom
lgtm
5 years, 6 months ago (2015-06-08 22:15:58 UTC) #2
nweiz
5 years, 6 months ago (2015-06-08 23:08:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68308887177ef3b78fdd52f068e4eaefe1b17e07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698