Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 11712002: Remove NoSuchMethodErrorImplementation class and use NoSuchMethodError from core (Closed)

Created:
7 years, 12 months ago by regis
Modified:
7 years, 11 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove NoSuchMethodErrorImplementation class and use NoSuchMethodError from core lib instead. Committed: https://code.google.com/p/dart/source/detail?r=16583

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -130 lines) Patch
M runtime/lib/error.cc View 1 1 chunk +0 lines, -38 lines 0 comments Download
M runtime/lib/error.dart View 1 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 3 chunks +63 lines, -42 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 11 chunks +53 lines, -24 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 12 months ago (2012-12-28 23:30:19 UTC) #1
srdjan
lgtm
7 years, 11 months ago (2013-01-02 18:47:32 UTC) #2
hausner
7 years, 11 months ago (2013-01-03 18:12:00 UTC) #3
Message was sent while issue was closed.
LGTM 2

Powered by Google App Engine
This is Rietveld 408576698