Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1171003002: Add d8 .gitignore and remove svn deps for d8 (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add d8 .gitignore and remove svn deps for d8 Add d8 sha files for version 4.4.63.5 Don't git ignore d8 in third_party R=sra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f76792f7c62a56bbe1a3bafb2f8d3a49ef9f66e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M DEPS View 3 chunks +15 lines, -3 lines 0 comments Download
M third_party/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/.gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/d8/README.google View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/d8/linux/d8.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/macos/d8.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/windows/d8.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 6 months ago (2015-06-09 13:22:37 UTC) #1
sra1
lgtm
5 years, 6 months ago (2015-06-09 20:55:53 UTC) #2
ricow1
5 years, 6 months ago (2015-06-10 10:52:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f76792f7c62a56bbe1a3bafb2f8d3a49ef9f66e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698