Issue 1170973002: update_homebrew: more fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1170973002: update_homebrew: more fixes (Closed)

Created:
5 years, 6 months ago by kevmoo

Modified:
5 years, 6 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, ricow1

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

update_homebrew: more fixes normalize top-level constants simplify file writing pop out variables to top-level constants R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/2e6d2a62244fd5ad14cfcff5312962c893991945

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -42 lines)			Patch
	M	tools/apps/update_homebrew/bin/update_homebrew.dart	View	1	5 chunks	+26 lines, -42 lines	0 comments	Download

Total messages: 4 (1 generated)

kevmoo

5 years, 6 months ago (2015-06-09 09:17:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2e6d2a62244fd5ad14cfcff5312962c893991945 (presubmit successful).