Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1170953004: update_homebrew: add optional resources content-shell and dartium to dart formula (Closed)

Created:
5 years, 6 months ago by kevmoo
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update_homebrew: add optional resources content-shell and dartium to dart formula deprecate dartium formula make -k optional remove extra version sets R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/09e8210c471effc6fb0c2e1d28eb5c0e773094b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 5 chunks +59 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 6 months ago (2015-06-09 11:22:48 UTC) #2
Bill Hesse
lgtm
5 years, 6 months ago (2015-06-09 11:41:24 UTC) #3
kevmoo
5 years, 6 months ago (2015-06-09 11:43:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09e8210c471effc6fb0c2e1d28eb5c0e773094b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698