Issue 1170863002: Remove extra CompileTimeErrorCode.DUPLICATE_DEFINITION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1170863002: Remove extra CompileTimeErrorCode.DUPLICATE_DEFINITION. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove extra CompileTimeErrorCode.DUPLICATE_DEFINITION. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/25620e2e592f43c28bfa598f91c3d3917774f36e

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+569 lines, -452 lines)			Patch
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+1 line, -2 lines	1 comment	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	3 chunks	+25 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/compile_time_error_code_test.dart	View	399 chunks	+543 lines, -448 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1170863002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1170863002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode11840 pkg/analyzer/lib/src/generated/resolver.dart:11840: * mapped to the name. Given that the ...

5 years, 6 months ago (2015-06-08 22:09:01 UTC) #2

scheglov

5 years, 6 months ago (2015-06-09 05:58:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
25620e2e592f43c28bfa598f91c3d3917774f36e (presubmit successful).

Expand Messages | Collapse Messages