Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1170543003: Pull in latest analyzer_cli. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull in latest analyzer_cli. The latest update to analyzer_cli makes it analyze all files using a single context, so it can re-use analysis results; this makes it much faster when analyzing large projects (~13x faster at analyzing pub, for example). On a temporary basis, this CL pulls in analyzer_cli using a git SHA rather than a tag, since the new analyzer_cli features don't have a release tag yet. Once they have been validated on the buildbots, I'll assign a release tag and update DEPS to point to it. R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/3fd32d4d0520bb248a93d1423c2013b7f2ee975c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 6 months ago (2015-06-05 15:58:02 UTC) #2
pquitslund
LGTM. Bombs away! :) https://codereview.chromium.org/1170543003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1170543003/diff/1/DEPS#newcode41 DEPS:41: "analyzer_cli_rev" : "@090c4859a2f88e62ae71a11583ba31e9999c74f6", As per ...
5 years, 6 months ago (2015-06-05 16:01:53 UTC) #3
Paul Berry
5 years, 6 months ago (2015-06-05 16:07:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fd32d4d0520bb248a93d1423c2013b7f2ee975c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698