Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170483002: Fixed breakpoint handling at return statement with inlined finally clauses. (Closed)

Created:
5 years, 6 months ago by regis
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed breakpoint handling at return statement with inlined finally clauses. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a5669190ab70ccdb069eb9a843cf19671c2e9299

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -12 lines) Patch
A runtime/observatory/tests/service/debugging_inlined_finally_test.dart View 1 chunk +127 lines, -0 lines 2 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 6 months ago (2015-06-03 22:17:18 UTC) #2
rmacnak
LGTM https://chromiumcodereview.appspot.com/1170483002/diff/1/runtime/observatory/tests/service/debugging_inlined_finally_test.dart File runtime/observatory/tests/service/debugging_inlined_finally_test.dart (right): https://chromiumcodereview.appspot.com/1170483002/diff/1/runtime/observatory/tests/service/debugging_inlined_finally_test.dart#newcode13 runtime/observatory/tests/service/debugging_inlined_finally_test.dart:13: debugger(); I have been setting breakpoints then doing ...
5 years, 6 months ago (2015-06-03 22:23:07 UTC) #3
regis
Thanks! https://chromiumcodereview.appspot.com/1170483002/diff/1/runtime/observatory/tests/service/debugging_inlined_finally_test.dart File runtime/observatory/tests/service/debugging_inlined_finally_test.dart (right): https://chromiumcodereview.appspot.com/1170483002/diff/1/runtime/observatory/tests/service/debugging_inlined_finally_test.dart#newcode13 runtime/observatory/tests/service/debugging_inlined_finally_test.dart:13: debugger(); On 2015/06/03 22:23:06, rmacnak wrote: > I ...
5 years, 6 months ago (2015-06-03 22:25:32 UTC) #4
regis
5 years, 6 months ago (2015-06-03 22:25:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a5669190ab70ccdb069eb9a843cf19671c2e9299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698