Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1169813007: Exclude Dartium from expected failures due to issue #23612. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exclude Dartium from expected failures due to issue #23612. These tests are marked as MissingCompileTimeError, and indeed Dartium gives a runtime error rather than a compile-time error. But the test framework doesn't seem to be able to tell the difference, so it incorrectly flags the test as passing. TBR=scheglov@google.com BUG=https://github.com/dart-lang/sdk/issues/23612 Committed: https://github.com/dart-lang/sdk/commit/046123935a10bb7b8bf85c69f3e8e6ca3a51b34e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tests/language/language.status View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Berry
Committed patchset #1 (id:1) manually as 046123935a10bb7b8bf85c69f3e8e6ca3a51b34e (presubmit successful).
5 years, 6 months ago (2015-06-09 21:53:16 UTC) #1
scheglov
5 years, 6 months ago (2015-06-09 22:19:46 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698