Issue 11698002: Fix instance of test for classes that implement call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11698002: Fix instance of test for classes that implement call. (Closed)

Created:
7 years, 12 months ago by srdjan

Modified:
7 years, 12 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix instance of test for classes that implement call. Committed: https://code.google.com/p/dart/source/detail?r=16541

Patch Set 2 : #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/isolate/port_test.dart	View	1	4 chunks	+14 lines, -14 lines	0 comments	Download
M	tests/language/call_operator_test.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11698002/diff/1/tests/isolate/port_test.dart File tests/isolate/port_test.dart (right): https://codereview.chromium.org/11698002/diff/1/tests/isolate/port_test.dart#newcode1 tests/isolate/port_test.dart:1: // Copyright (c) 2011, the Dart project authors. ...

7 years, 12 months ago (2012-12-28 01:42:12 UTC) #2

srdjan

7 years, 12 months ago (2012-12-28 16:11:55 UTC) #3

https://codereview.chromium.org/11698002/diff/1/tests/isolate/port_test.dart
File tests/isolate/port_test.dart (right):

https://codereview.chromium.org/11698002/diff/1/tests/isolate/port_test.dart#...
tests/isolate/port_test.dart:1: // Copyright (c) 2011, the Dart project authors.
 Please see the AUTHORS file
On 2012/12/28 01:42:12, regis wrote:
> 2012

Done.

Expand Messages | Collapse Messages

Issue 11698002: Fix instance of test for classes that implement call. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages