Issue 11697011: Fixing up history test to pass properly on supported platforms.

Issue 11697011: Fixing up history test to pass properly on supported platforms. (Closed)

Created:
7 years, 12 months ago by blois

Modified:
7 years, 12 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing up history test to pass properly on supported platforms. The primary problem was that on some browsers the state change doesn't take effect until the popState event has been called, so I added a check for that. Also added a support flag for IE9. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16562

Patch Set 1 #

Patch Set 2 : Fixing dartium. #

Total comments: 3

Patch Set 3 : #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -19 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+20 lines, -4 lines	0 comments	Download
A +	sdk/lib/html/templates/html/impl/impl_History.darttemplate	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/html/history_test.dart	View		1 chunk	+59 lines, -11 lines	0 comments	Download
M	tests/html/html.status	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	tools/dom/templates/html/impl/impl_History.darttemplate	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://codereview.chromium.org/11697011/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11697011/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode9811 sdk/lib/html/dart2js/html_dart2js.dart:9811: @SupportedBrowser(SupportedBrowser.CHROME) @SupportedBrowser(SupportedBrowser.FIREFOX) @SupportedBrowser(SupportedBrowser.IE, '10') @SupportedBrowser(SupportedBrowser.SAFARI) Can these be ...

7 years, 12 months ago (2012-12-28 22:58:54 UTC) #2

blois

7 years, 12 months ago (2012-12-28 23:03:45 UTC) #3

https://codereview.chromium.org/11697011/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11697011/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:9811:
@SupportedBrowser(SupportedBrowser.CHROME)
@SupportedBrowser(SupportedBrowser.FIREFOX)
@SupportedBrowser(SupportedBrowser.IE, '10')
@SupportedBrowser(SupportedBrowser.SAFARI)
On 2012/12/28 22:58:54, Emily Fortuna wrote:
> Can these be on separate lines? 

Requires a refactor of the dart2js annotations- currently it only supports
single line.

I would like to do this (I made the Dartium one do it correctly), but this one
is piggy-backed on top of the existing dart2js annotations and I need to
coordinate with Stephen. 

So, yes, but prefer not this CL.

Expand Messages | Collapse Messages