Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 11696004: Removing noSuchMethod from Element. (Closed)

Created:
7 years, 12 months ago by blois
Modified:
7 years, 12 months ago
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Removing noSuchMethod from Element. This was added to support WebComponents, but was only implemented for Dartium, not Dart2JS. It's not currently being used by web components and is not something we can support in Dart2JS, so removing the functionality and re-enabling the tests. BUG=4189 Committed: https://code.google.com/p/dart/source/detail?r=16546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +0 lines, -18 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 2 chunks +0 lines, -22 lines 0 comments Download
M tests/html/html.status View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/html/unknownelement_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 12 months ago (2012-12-28 01:19:44 UTC) #1
Siggi Cherem (dart-lang)
7 years, 12 months ago (2012-12-28 01:27:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698