Issue 11696002: Filling in supported platforms for InputElement types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11696002: Filling in supported platforms for InputElement types. (Closed)

Created:
7 years, 12 months ago by blois

Modified:
7 years, 12 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Filling in supported platforms for InputElement types. This fixes up some syntax issues with the first CL (parens on getters). Also fixes an issue on IE where the constructors threw unexpected exceptions. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16551

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+392 lines, -146 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	10 chunks	+81 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1	9 chunks	+81 lines, -2 lines	1 comment	Download
M	sdk/lib/html/scripts/systemhtml.py	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_HTMLInputElement.darttemplate	View	1	9 chunks	+86 lines, -0 lines	1 comment	Download
M	tests/html/html.status	View		5 chunks	+33 lines, -33 lines	0 comments	Download
M	tests/html/input_element_test.dart	View		1 chunk	+111 lines, -108 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 12 months ago (2012-12-28 01:42:33 UTC) #2

lgtm with one suggestion

https://codereview.chromium.org/11696002/diff/2001/sdk/lib/html/dartium/html_...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/11696002/diff/2001/sdk/lib/html/dartium/html_...
sdk/lib/html/dartium/html_dartium.dart:13328: static bool get supported {
parens not on getters. still gets me every time!

https://codereview.chromium.org/11696002/diff/2001/sdk/lib/html/templates/htm...
File sdk/lib/html/templates/html/impl/impl_HTMLInputElement.darttemplate
(right):

https://codereview.chromium.org/11696002/diff/2001/sdk/lib/html/templates/htm...
sdk/lib/html/templates/html/impl/impl_HTMLInputElement.darttemplate:44: 
delete the whitespace here. that's what's adding those extra lines in the
generated html_dart2js

Expand Messages | Collapse Messages