Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1169453005: dart2js: Ensure that typevariables of superclasses are also emitted. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
karlklose, zarah
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Identified root cause, new fix. #

Patch Set 3 : Take top-level fields into account #

Patch Set 4 : Use null as type. #

Patch Set 5 : Indentation fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 2 3 4 1 chunk +12 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (1 generated)
herhut
5 years, 6 months ago (2015-06-03 13:16:23 UTC) #1
zarah
LGTM!
5 years, 6 months ago (2015-06-04 08:40:00 UTC) #2
karlklose
On 2015/06/04 08:40:00, zarah wrote: > LGTM! DBC: is there any way to test this?
5 years, 6 months ago (2015-06-04 09:31:40 UTC) #3
herhut
PTAL
5 years, 6 months ago (2015-06-04 12:37:49 UTC) #4
karlklose
LGTM.
5 years, 6 months ago (2015-06-04 13:01:23 UTC) #6
herhut
Committed patchset #2 (id:20001) manually as 67537ffbd7657bf8e679f8d677d658d096e5c7af (presubmit successful).
5 years, 6 months ago (2015-06-08 09:27:27 UTC) #7
herhut
PTAL. I had to revert as top-level fields have no enclosing class.
5 years, 6 months ago (2015-06-08 10:46:28 UTC) #8
zarah
LGTM
5 years, 6 months ago (2015-06-08 10:52:53 UTC) #9
herhut
Committed patchset #3 (id:40001) manually as a1b630641e86eb862bbec1d4b84ce8c2eb9d6f65 (presubmit successful).
5 years, 6 months ago (2015-06-08 10:54:00 UTC) #10
herhut
I had to revert again. I know have added support for partially reflectable fields to ...
5 years, 6 months ago (2015-06-08 13:04:43 UTC) #11
karlklose
LGTM.
5 years, 6 months ago (2015-06-08 13:33:30 UTC) #12
herhut
5 years, 6 months ago (2015-06-08 13:35:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
e4255659dddd6e733c51318745c72582c7f43e06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698