Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1169453002: Add an option for percent-encoding of the padding character to Base64Codec (Closed)

Created:
5 years, 6 months ago by Alexander Ivanov
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an option for percent-encoding of the padding character to Base64Codec Adds an encodePaddingCharacter parameter to Base64 codec and encoder. Decode '%3D' as '=' in Base64 decoder BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/crypto/commit/d4558dea1639e5ad2a41d045265b8ece270c2d90

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix formatting according to issue comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -35 lines) Patch
M lib/src/base64.dart View 1 12 chunks +127 lines, -35 lines 0 comments Download
M test/base64_test.dart View 1 5 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alexander Ivanov
5 years, 6 months ago (2015-06-02 14:12:50 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1169453002/diff/1/lib/src/base64.dart File lib/src/base64.dart (right): https://codereview.chromium.org/1169453002/diff/1/lib/src/base64.dart#newcode98 lib/src/base64.dart:98: encodePaddingCharacter: _encodePaddingCharacter); Long line. I will probably format ...
5 years, 6 months ago (2015-06-03 11:32:04 UTC) #3
Alexander Ivanov
5 years, 6 months ago (2015-06-03 11:54:30 UTC) #4
Alexander Ivanov
5 years, 6 months ago (2015-06-03 11:56:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d4558dea1639e5ad2a41d045265b8ece270c2d90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698