Issue 1169433002: Remove pkg_tested from the default selector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1169433002: Remove pkg_tested from the default selector (Closed)

Created:
5 years, 6 months ago by ricow1

Modified:
5 years, 6 months ago

Reviewers:
Bob Nystrom, Florian Schneider, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove pkg_tested from the default selector We now pull in pub from github into pkg_tested and we don't want to run those tests by default Also, the pub tests relies on the sdk being build, so the tests will fail if you don't explicitly specify --use-sdk to the tools/test.py invocation. R=fschneider@google.com, rnystrom@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9db675f73445bbd75205eba398d299965e63e57b

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tools/bots/cross-vm.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/testing/dart/test_options.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

ricow1

Committed patchset #1 (id:1) manually as 9db675f73445bbd75205eba398d299965e63e57b (presubmit successful).

5 years, 6 months ago (2015-06-02 12:31:32 UTC) #2

Message was sent while issue was closed.

lgtm