Issue 11694009: Move common logic into the base class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11694009: Move common logic into the base class. (Closed)

Created:
7 years, 12 months ago by Anton Muhin

Modified:
7 years, 11 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move common logic into the base class. R=cshapiro@google.com Committed: https://code.google.com/p/dart/source/detail?r=16915

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -192 lines)			Patch
	M	runtime/lib/byte_array.dart	View	1	23 chunks	+116 lines, -192 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cshapiro

https://codereview.chromium.org/11694009/diff/1/runtime/lib/byte_array.dart File runtime/lib/byte_array.dart (right): https://codereview.chromium.org/11694009/diff/1/runtime/lib/byte_array.dart#newcode1811 runtime/lib/byte_array.dart:1811: final ByteArray _array; Can you move the private field ...

7 years, 11 months ago (2013-01-07 23:25:58 UTC) #2

Anton Muhin

7 years, 11 months ago (2013-01-09 15:35:57 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 11694009: Move common logic into the base class. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages