In unoptimized code use call for instanceof instead of inlined checks. This allows us to collect ty…

In unoptimized code use call for instanceof instead of inlined checks. This allows us to collect type feedback and to reduce the code size of unoptimized code. Next will be work on type tests as well.
Committed: https://code.google.com/p/dart/source/detail?r=16589

[regis, 2012-12-28 19:46:49]

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object.cc#newc...
runtime/lib/object.cc:68: // Instantiator at pos 1 is not used.
Do you need it for type feedback? Also, a comment explaining why you need this
call would be useful.

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object.cc#newc...
runtime/lib/object.cc:79: ASSERT(malformed_error.IsNull());
Instantiating a type with a type argument that is not extending the declared
upper bound results in a malformed type. How can this assert be correct? I
realize you filed a related bug.

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object_patch.dart
File runtime/lib/object_patch.dart (right):

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object_patch.d...
runtime/lib/object_patch.dart:39: _instanceOf(instantiator,
Add a comment about the usefulness of this call.

[srdjan, 2013-01-02 20:38:46]

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object.cc#newc...
runtime/lib/object.cc:68: // Instantiator at pos 1 is not used.
On 2012/12/28 19:46:49, regis wrote:
> Do you need it for type feedback? Also, a comment explaining why you need this
> call would be useful.

Added comment:
  // Instantiator at position 1 is not used. It is passed along so that the call
  // can be easily converted to an optimized implementation. Instantiator is
  // the used to populate the subtype cache.

Adding comment to object_patch.dart:
  // Call this function instead of inlining instanceof, thus collecting
  // type feedback and reducing code size of unoptimized code.

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object.cc#newc...
runtime/lib/object.cc:79: ASSERT(malformed_error.IsNull());
On 2012/12/28 19:46:49, regis wrote:
> Instantiating a type with a type argument that is not extending the declared
> upper bound results in a malformed type. How can this assert be correct? I
> realize you filed a related bug.

Fixed.

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object_patch.dart
File runtime/lib/object_patch.dart (right):

https://codereview.chromium.org/11694003/diff/2005/runtime/lib/object_patch.d...
runtime/lib/object_patch.dart:39: _instanceOf(instantiator,
On 2012/12/28 19:46:49, regis wrote:
> Add a comment about the usefulness of this call.

Done.

[regis, 2013-01-02 21:11:52]

LGTM

https://codereview.chromium.org/11694003/diff/25001/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11694003/diff/25001/runtime/lib/object.cc#new...
runtime/lib/object.cc:73: // the used to populate the subtype cache.
remove "the".

[srdjan, 2013-01-02 21:47:12]

https://codereview.chromium.org/11694003/diff/25001/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11694003/diff/25001/runtime/lib/object.cc#new...
runtime/lib/object.cc:73: // the used to populate the subtype cache.
On 2013/01/02 21:11:52, regis wrote:
> remove "the".

Done.