Issue 11688005: Start unification of overload dispatcher generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11688005: Start unification of overload dispatcher generation. (Closed)

Created:
7 years, 12 months ago by Anton Muhin

Modified:
7 years, 11 months ago

Reviewers:
podivilov, sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Start unification of overload dispatcher generation. Refactor checks generation and share it across backends. R=blois@google.com,podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=16570

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -67 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2	4 chunks	+12 lines, -12 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 2	10 chunks	+16 lines, -16 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 2	9 chunks	+24 lines, -12 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2	1 chunk	+6 lines, -15 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2	4 chunks	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://codereview.chromium.org/11688005/diff/8/sdk/lib/html/scripts/systemhtml.py File sdk/lib/html/scripts/systemhtml.py (right): https://codereview.chromium.org/11688005/diff/8/sdk/lib/html/scripts/systemhtml.py#newcode806 sdk/lib/html/scripts/systemhtml.py:806: self._OverloadChecks( maybe introduce a local?

7 years, 12 months ago (2012-12-28 16:17:16 UTC) #2

Anton Muhin

7 years, 11 months ago (2012-12-29 12:02:12 UTC) #3

Again, Pavel, thanks a lot for review and I am submitting it.

I'd be happy to address any concerns by Pete and Stephen.

https://codereview.chromium.org/11688005/diff/8/sdk/lib/html/scripts/systemht...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11688005/diff/8/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:806: self._OverloadChecks(
On 2012/12/28 16:17:16, podivilov wrote:
> maybe introduce a local?

Let's see how the things will unfold.

Expand Messages | Collapse Messages

Issue 11688005: Start unification of overload dispatcher generation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages