Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1168743002: Reanalyze after creating a referenced part. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reanalyze after creating a referenced part. We need to finish linking CompilationUnitElement(s) to LibraryElement(s) even for not existing sources. Otherwise we get NPE later and leave model in the ERROR state. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/787e9fcf7f11a8a0dcd8a7900a962cb24506cdc9

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 2 chunks +10 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +20 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 2 chunks +2 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 6 months ago (2015-06-05 18:17:09 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1168743002/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/1168743002/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode428 pkg/analyzer/lib/src/context/cache.dart:428: // { Did you intend to include this ...
5 years, 6 months ago (2015-06-05 18:24:48 UTC) #2
scheglov
https://codereview.chromium.org/1168743002/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/1168743002/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode428 pkg/analyzer/lib/src/context/cache.dart:428: // { On 2015/06/05 18:24:48, Brian Wilkerson wrote: > ...
5 years, 6 months ago (2015-06-05 18:28:24 UTC) #3
scheglov
5 years, 6 months ago (2015-06-05 18:29:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
787e9fcf7f11a8a0dcd8a7900a962cb24506cdc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698