Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1168563004: Fix a corner case of constant constructor dependency computation. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a corner case of constant constructor dependency computation. If a constant constructor does not contain an explicit call to super(), and the base class lacks an explicit constructor, we need to avoid marking the implicit base class constructor as a dependency, since it is non-const. (Note: this shouldn't occur very often in real-world usage since is a compile-time error, but we still need to be able to analyze it without throwing an exception). Fixes the following test when the new task model is switched on: co19/Language/07_Classes/6_Constructors/3_Constant_Constructors_A03_t02 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/12696cafe9939cec03542b918bbc7019a9bff9a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 6 months ago (2015-06-08 17:52:22 UTC) #2
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-08 18:01:31 UTC) #3
Paul Berry
5 years, 6 months ago (2015-06-08 18:23:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12696cafe9939cec03542b918bbc7019a9bff9a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698