Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1168393003: Enforce LF line endings in the git database. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
ricow1, nweiz
CC:
reviews_dartlang.org, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments and rebase #

Patch Set 3 : addes missing .gitattributes #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13537 lines, -13518 lines) Patch
A .gitattributes View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/async_await_syntax_test.dart View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/end2end_test.dart View 1 2 3 1 chunk +36 lines, -36 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr2_test.dart View 1 2 3 1 chunk +61 lines, -61 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/test_helper.dart View 1 2 3 1 chunk +46 lines, -46 lines 0 comments Download
M tests/compiler/dart2js/check_members_test.dart View 1 2 3 1 chunk +53 lines, -53 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 2 3 1 chunk +237 lines, -237 lines 0 comments Download
M tests/compiler/dart2js/exit_code_helper.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/frontend_checker.dart View 1 2 3 1 chunk +110 lines, -110 lines 0 comments Download
M tests/compiler/dart2js/import_mirrors_test.dart View 1 2 3 1 chunk +413 lines, -413 lines 0 comments Download
M tests/compiler/dart2js/instantiated_classes_test.dart View 1 2 3 1 chunk +85 lines, -85 lines 0 comments Download
M tests/compiler/dart2js/least_upper_bound_language_test.dart View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 1 2 3 1 chunk +852 lines, -852 lines 0 comments Download
M tests/compiler/dart2js/line_column_provider_test.dart View 1 2 3 1 chunk +84 lines, -84 lines 0 comments Download
M tests/compiler/dart2js/mirror_system_helper.dart View 1 2 3 1 chunk +139 lines, -139 lines 0 comments Download
M tests/compiler/dart2js/mirrors/class_mirror_type_variables_test.dart View 1 2 3 1 chunk +42 lines, -42 lines 0 comments Download
M tests/compiler/dart2js/mirrors/default_value_test.dart View 1 2 3 1 chunk +62 lines, -62 lines 0 comments Download
M tests/compiler/dart2js/mirrors/library_exports_hidden_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/library_exports_shown_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/library_imports_hidden_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/library_imports_prefixed_show_hide_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/library_imports_prefixed_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/library_imports_shown_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/mirrors_reader_test.dart View 1 2 3 1 chunk +141 lines, -141 lines 0 comments Download
M tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 2 3 1 chunk +36 lines, -36 lines 0 comments Download
M tests/compiler/dart2js/mirrors/relation_assignable_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/relation_subclass_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors/relation_subtype_test.dart View 1 2 3 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors_exports_test.dart View 1 2 3 1 chunk +182 lines, -182 lines 0 comments Download
M tests/compiler/dart2js/mirrors_mixin_test.dart View 1 2 3 1 chunk +239 lines, -239 lines 0 comments Download
M tests/compiler/dart2js/mixin_language_test.dart View 1 2 3 1 chunk +21 lines, -21 lines 0 comments Download
M tests/compiler/dart2js/mixin_typevariable_test.dart View 1 2 3 1 chunk +158 lines, -158 lines 0 comments Download
M tests/compiler/dart2js/override_inheritance_test.dart View 1 2 3 1 chunk +1546 lines, -1546 lines 0 comments Download
M tests/compiler/dart2js/proxy_test.dart View 1 2 3 1 chunk +22 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 2 3 1 chunk +706 lines, -706 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_decl_data.dart View 1 2 3 1 chunk +870 lines, -870 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_decl_visitor.dart View 1 2 3 1 chunk +483 lines, -483 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 2 3 1 chunk +3567 lines, -3567 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 1 2 3 1 chunk +2943 lines, -2943 lines 0 comments Download
M tests/compiler/dart2js/type_order_test.dart View 1 2 3 1 chunk +71 lines, -71 lines 0 comments Download
M tests/compiler/dart2js/type_promotion_test.dart View 1 2 3 1 chunk +29 lines, -29 lines 0 comments Download
M tests/compiler/dart2js/warnings_checker.dart View 1 2 3 1 chunk +83 lines, -83 lines 0 comments Download
M tests/compiler/dart2js_extra/string_interpolation_dynamic_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/string_interpolation_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
herhut
We have quite some files that have CRLF endings. I propose to let git deal ...
5 years, 6 months ago (2015-06-09 13:02:54 UTC) #2
nweiz
https://codereview.chromium.org/1168393003/diff/1/.gitattributes File .gitattributes (right): https://codereview.chromium.org/1168393003/diff/1/.gitattributes#newcode14 .gitattributes:14: *.bat -text Is there actually a reason not to ...
5 years, 6 months ago (2015-06-09 19:11:50 UTC) #3
ricow1
https://codereview.chromium.org/1168393003/diff/1/tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart File tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart (right): https://codereview.chromium.org/1168393003/diff/1/tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart#newcode5 tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart:5: // This file is marked executable so source control ...
5 years, 6 months ago (2015-06-09 19:16:12 UTC) #4
herhut
PTAL Johnni tried for me on windows and it worked fine. https://codereview.chromium.org/1168393003/diff/1/.gitattributes File .gitattributes (right): ...
5 years, 6 months ago (2015-06-24 07:42:30 UTC) #5
ricow1
lgtm
5 years, 6 months ago (2015-06-24 07:44:35 UTC) #6
herhut
5 years, 6 months ago (2015-06-25 11:42:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:30001) manually as
b1c1606e17f1302c67de06f6a88ac56d229ef334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698