Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 1167773002: Record SourceKind.UNKNOWN for not existing sources. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record SourceKind.UNKNOWN for not existing sources. So, they are not returned as library sources. This fixes one of the Quick Fix tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/958638ca2098d1f8bfdc17adba08002382b894d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 4 chunks +11 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-02 20:06:45 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-02 20:17:31 UTC) #2
scheglov
5 years, 6 months ago (2015-06-02 20:19:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
958638ca2098d1f8bfdc17adba08002382b894d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698