Decide if unit without directives is a part or a library.

Decide if unit without directives is a part or a library.

1. When there is a library containing it while we are parsing a part.

2. When a part was parsed, but then we found a library containing it.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b35d54a8b768c7871596db14fd454a5d8351870b

[Brian Wilkerson, 2015-06-02 22:01:53]

LGTM, given that it improves the situation, but we should at least add a TODO to
come back and find a complete fix at some point.

https://codereview.chromium.org/1167733004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1167733004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2679: if
(context.getLibrariesContaining(source).isEmpty) {
While this is better, it doesn't work reliably. If we choose to parse the part
file before we parse the including library we'll incorrectly assume that it's a
library (rather than the part it really is).

I'm not sure what the right solution is, though.

[scheglov, 2015-06-02 22:56:41]

https://codereview.chromium.org/1167733004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1167733004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2679: if
(context.getLibrariesContaining(source).isEmpty) {
On 2015/06/02 22:01:53, Brian Wilkerson wrote:
> While this is better, it doesn't work reliably. If we choose to parse the part
> file before we parse the including library we'll incorrectly assume that it's
a
> library (rather than the part it really is).
> 
> I'm not sure what the right solution is, though.

Right.
That's there is also the change in DartWorkManager.
If we detect that the source is a part of a library, we change its SOURCE_KIND
and remove LibrarySpecificUnit(part, part).

[scheglov, 2015-06-02 23:01:07]

Committed patchset #1 (id:1) manually as
b35d54a8b768c7871596db14fd454a5d8351870b (presubmit successful).

[Brian Wilkerson, 2015-06-02 23:07:39]

> That's there is also the change in DartWorkManager.

Sorry, I missed the implications of that part of the change. That's a problem
for two reasons.

First, it will produce the wrong result in the case where one library tries to
include another library using a 'part' directive (but only sometimes, depending
on the order in which they are parsed, so it's non-deterministic).

Second, we're computing analysis results outside of the task model. If the task
model cannot express the work that needs to be performed, then we need to fix it
rather than work around it.