Issue 116773003: Re-apply: Fix regression on side effects of tdiv.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 116773003: Re-apply: Fix regression on side effects of tdiv. (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
lukas

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -2 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
A	tests/compiler/dart2js/side_effect_tdiv_regression_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

Patchset 1 contains the original CL (already reviewed) Patchset 2 contains the fix.

7 years ago (2013-12-18 09:10:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r31216 (presubmit successful).