Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1167583002: Canonicalize mixin type during class finalization. Add asserts that most types are canonical. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
regis, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Canonicalize mixin type during class finalization. Add asserts that most types are canonical. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/4102b0c446e7068daa285a81b644e4e06ea66e30

Patch Set 1 #

Total comments: 2

Patch Set 2 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M runtime/lib/mirrors.cc View 1 12 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 6 months ago (2015-05-29 22:02:36 UTC) #2
regis
lgtm https://codereview.chromium.org/1167583002/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/1167583002/diff/1/runtime/lib/mirrors.cc#newcode519 runtime/lib/mirrors.cc:519: PROPOGATE_IF_MALFOMRED(type); Raelly? :-)
5 years, 6 months ago (2015-05-29 22:16:50 UTC) #3
rmacnak
https://codereview.chromium.org/1167583002/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/1167583002/diff/1/runtime/lib/mirrors.cc#newcode519 runtime/lib/mirrors.cc:519: PROPOGATE_IF_MALFOMRED(type); On 2015/05/29 22:16:50, regis wrote: > Raelly? :-) ...
5 years, 6 months ago (2015-05-29 22:22:02 UTC) #4
rmacnak
5 years, 6 months ago (2015-05-29 22:29:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4102b0c446e7068daa285a81b644e4e06ea66e30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698