Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1167533005: Revert "Remove pkg_tested from the default selector" (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove pkg_tested from the default selector" This reverts commit 9db675f73445bbd75205eba398d299965e63e57b. Need to discuss this with other people R=fschneider@google.com,whesse@google.com,rnystrom@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6a054d5cc7a0e305cb4624c808c1721b06824b76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/bots/cross-vm.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
5 years, 6 months ago (2015-06-02 12:39:56 UTC) #1
ricow1
Committed patchset #1 (id:1) manually as 6a054d5cc7a0e305cb4624c808c1721b06824b76 (presubmit successful).
5 years, 6 months ago (2015-06-02 12:40:31 UTC) #2
Bill Hesse
lgtm
5 years, 6 months ago (2015-06-02 13:42:59 UTC) #3
Bob Nystrom
5 years, 6 months ago (2015-06-02 16:22:25 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698