Issue 1167483004: Invalidate resolution of analysisOptions/sourceFactory changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1167483004: Invalidate resolution of analysisOptions/sourceFactory changes. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Invalidate resolution of analysisOptions/sourceFactory changes. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/811877df42e36f57d08141d68f4e6b06ccc60d2c

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -79 lines)			Patch
M	pkg/analysis_server/test/domain_analysis_test.dart	View	2 chunks	+13 lines, -14 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/context.dart	View	4 chunks	+4 lines, -54 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	2 chunks	+11 lines, -0 lines	1 comment	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View	3 chunks	+64 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/task/dart_work_manager_test.dart	View	3 chunks	+66 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1167483004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1167483004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode9070 pkg/analyzer/lib/src/generated/engine.dart:9070: dynamic get privateAnalysisCachePartition; I'm not fond of the ...

5 years, 6 months ago (2015-06-05 21:01:34 UTC) #2

scheglov

5 years, 6 months ago (2015-06-05 21:09:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
811877df42e36f57d08141d68f4e6b06ccc60d2c (presubmit successful).

Expand Messages | Collapse Messages