Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1167353003: Opt-in to generate code for compile-time error. Only supported for SSA. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Opt-in to generate code for compile-time error. Only supported for SSA. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/bac7481d3d2816dbfa40d34e3cb54c4197684456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -19 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 6 chunks +23 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +14 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/generate_code_with_compile_time_errors_test.dart View 1 chunk +142 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-09 12:11:23 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-06-09 12:19:02 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-09 12:36:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bac7481d3d2816dbfa40d34e3cb54c4197684456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698