Issue 116703003: Fix crash walking call stack on Linux.

Issue 116703003: Fix crash walking call stack on Linux. (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix crash walking call stack on Linux. BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31192

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
M	runtime/vm/profiler.cc	View		3 chunks	+16 lines, -3 lines	0 comments	Download
M	runtime/vm/thread_interrupter.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM without the compile flags change. https://codereview.chromium.org/116703003/diff/1/tools/gyp/configurations_make.gypi File tools/gyp/configurations_make.gypi (right): https://codereview.chromium.org/116703003/diff/1/tools/gyp/configurations_make.gypi#newcode109 tools/gyp/configurations_make.gypi:109: '-mno-omit-leaf-frame-pointer', Does chrome ...

7 years ago (2013-12-17 16:47:51 UTC) #2

Cutch

On 2013/12/17 16:47:51, siva wrote: > LGTM without the compile flags change. > > https://codereview.chromium.org/116703003/diff/1/tools/gyp/configurations_make.gypi ...

7 years ago (2013-12-17 16:48:40 UTC) #3

Cutch

On 2013/12/17 16:47:51, siva wrote: > LGTM without the compile flags change. > > https://codereview.chromium.org/116703003/diff/1/tools/gyp/configurations_make.gypi ...

7 years ago (2013-12-17 16:48:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31192 (presubmit successful).

Expand Messages | Collapse Messages