Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 11669013: Document date format initialization better and make it possible to use en_US dates without it (Closed)

Created:
8 years ago by Alan Knight
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Document date format initialization better and make it possible to use en_US dates without it dartbug.com/6567 Committed: https://code.google.com/p/dart/source/detail?r=16582

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -18 lines) Patch
M pkg/intl/lib/date_format.dart View 1 1 chunk +30 lines, -2 lines 0 comments Download
M pkg/intl/lib/date_symbols.dart View 1 chunk +90 lines, -1 line 0 comments Download
M pkg/intl/lib/src/date_format_internal.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/intl_helpers.dart View 2 chunks +10 lines, -8 lines 0 comments Download
M pkg/intl/test/date_time_format_test_core.dart View 1 2 3 5 chunks +17 lines, -5 lines 0 comments Download
A pkg/intl/test/date_time_format_uninitialized_test.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
This provides better documentation of the need to initialize things. And while I was at ...
8 years ago (2012-12-21 21:55:20 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11669013/diff/3001/pkg/intl/lib/date_format.dart File pkg/intl/lib/date_format.dart (right): https://codereview.chromium.org/11669013/diff/3001/pkg/intl/lib/date_format.dart#newcode8 pkg/intl/lib/date_format.dart:8: // feedback on appropriateness. danke schön :-) https://codereview.chromium.org/11669013/diff/3001/pkg/intl/test/date_time_format_test_core.dart File ...
8 years ago (2012-12-21 23:30:23 UTC) #2
Alan Knight
https://codereview.chromium.org/11669013/diff/3001/pkg/intl/test/date_time_format_test_core.dart File pkg/intl/test/date_time_format_test_core.dart (right): https://codereview.chromium.org/11669013/diff/3001/pkg/intl/test/date_time_format_test_core.dart#newcode231 pkg/intl/test/date_time_format_test_core.dart:231: testLocale("en_US", English, aDate); On 2012/12/21 23:30:23, Emily Fortuna wrote: ...
8 years ago (2012-12-21 23:34:25 UTC) #3
Emily Fortuna
8 years ago (2012-12-21 23:34:52 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698