Issue 1166813002: --check_function_fingerprints is available only in dart_no_snapshot, i.e., it was not tested. Make …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166813002: --check_function_fingerprints is available only in dart_no_snapshot, i.e., it was not tested. Make … (Closed)

Created:
5 years, 6 months ago by srdjan

Modified:
5 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

--check_function_fingerprints is available only in dart_no_snapshot, i.e., it was not tested. Make it default true, catch failure at build time then BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/defec9c960a214491b8a4a126582577cc154d28e

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/language/bootstrap_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 6 months ago (2015-06-02 23:37:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
defec9c960a214491b8a4a126582577cc154d28e (presubmit successful).