Issue 11668005: Removed debugging information in the testing infrastructure and added a warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11668005: Removed debugging information in the testing infrastructure and added a warning (Closed)

Created:
8 years ago by kustermann

Modified:
8 years ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removed debugging information in the testing infrastructure and added a warning Committed: https://code.google.com/p/dart/source/detail?r=16434

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -38 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View	1	3 chunks	+13 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years ago (2012-12-21 10:21:18 UTC) #2

LGTM!

https://codereview.chromium.org/11668005/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (left):

https://codereview.chromium.org/11668005/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:634: printDebug("Test failure because of
missing XDisplay");
Keep this message?

Expand Messages | Collapse Messages