Issue 1166783002: Factor in the Dart repo's state for snapshotting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166783002: Factor in the Dart repo's state for snapshotting. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Factor in the Dart repo's state for snapshotting. When I originally wrote this code, I hadn't thought about running tests from within the Dart repo itself, so the snapshotting logic didn't work for that case. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/6f8ae035883550bfaa690be3aa96f0d2dd8787d7

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -6 lines)			Patch
	M	pubspec.yaml	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	test/test_pub.dart	View	1	3 chunks	+22 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

nweiz

PTAL; I changed this to just hash the Dart executable itself, since that's what matters.

5 years, 6 months ago (2015-06-02 21:31:33 UTC) #2

nweiz

5 years, 6 months ago (2015-06-02 21:36:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6f8ae035883550bfaa690be3aa96f0d2dd8787d7 (presubmit successful).