Issue 1166653002: Revert "Trust inferred type when propagating types in the SSA backend."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166653002: Revert "Trust inferred type when propagating types in the SSA backend." (Closed)

Created:
5 years, 6 months ago by karlklose

Modified:
5 years, 6 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Trust inferred type when propagating types in the SSA backend." This uncovered a bug in optimizations that would introduce a return into an async* function. This reverts commit 8a544b0754537fc873f5ce622a09e5e72d74f66f. R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/44f04fa0f75f11ceba4d9a42c7e13faaa021c1a5

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	pkg/compiler/lib/src/ssa/types_propagation.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

karlklose

Committed patchset #1 (id:1) manually as 44f04fa0f75f11ceba4d9a42c7e13faaa021c1a5 (presubmit successful).

5 years, 6 months ago (2015-06-01 08:27:50 UTC) #2

Message was sent while issue was closed.

LGTM