Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1166503004: Add correct test for issue 23523 (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M pkg/analyzer/test/generated/element_test.dart View 2 chunks +33 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
The wrong behavior (which has already been fixed) depends on telling the parser to skip ...
5 years, 6 months ago (2015-06-05 16:13:23 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-05 16:16:48 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-05 16:20:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba4523df1af830490624208d2bff87d827667746 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698