Issue 11665004: Add exitCode setter to set the exit code returned by the Dart VM

Issue 11665004: Add exitCode setter to set the exit code returned by the Dart VM (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Bob Nystrom, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add exitCode setter to set the exit code returned by the Dart VM standalone binary on normal termination. This is needed to be able to set the exit code without cutting off pending asynchronous operations. R=sgjesse@google.com,rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16435

Patch Set 1 #

Patch Set 2 : Actually upload the correct patch #

Total comments: 2

Patch Set 3 : Address comments. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -17 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/process.h	View	1	3 chunks	+15 lines, -0 lines	0 comments	Download
M	runtime/bin/process.cc	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download
M	runtime/bin/process_patch.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/io/process.dart	View		1 chunk	+22 lines, -2 lines	0 comments	Download
A +	tests/standalone/io/process_set_exit_code_script.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
A	tests/standalone/io/process_set_exit_code_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/11665004/diff/2001/runtime/bin/process.cc File runtime/bin/process.cc (right): https://codereview.chromium.org/11665004/diff/2001/runtime/bin/process.cc#newcode188 runtime/bin/process.cc:188: Dart_ExitScope(); Move Dart_ExitScope to the end of the ...

8 years ago (2012-12-21 10:01:05 UTC) #2

Mads Ager (google)

8 years ago (2012-12-21 10:37:40 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11665004/diff/2001/runtime/bin/process.cc
File runtime/bin/process.cc (right):

https://codereview.chromium.org/11665004/diff/2001/runtime/bin/process.cc#new...
runtime/bin/process.cc:188: Dart_ExitScope();
On 2012/12/21 10:01:06, Søren Gjesse wrote:
> Move Dart_ExitScope to the end of the function.

That comment looks familiar. I forgot to move that over. Sorry! :-)

Expand Messages | Collapse Messages