Adjustments to next Chrome roll.

Adjustments to next Chrome roll.

Committed: https://code.google.com/p/dart/source/detail?r=16472

[antonm, 2012-12-21 15:38:12]

Changes necessary for a next Chrome roll.

https://codereview.chromium.org/11664009/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/html.status#newcode22
tests/html/html.status:22: audiocontext_test: Skip # Need to adjust to new API.
it looks like they migrate to OfflineAudioContext with _mandatory_ arguments.

https://codereview.chromium.org/11664009/diff/1/tests/html/indexeddb_3_test.dart
File tests/html/indexeddb_3_test.dart (left):

https://codereview.chromium.org/11664009/diff/1/tests/html/indexeddb_3_test.d...
tests/html/indexeddb_3_test.dart:25: on DatabaseException catch(e) { }  //
Chrome
DatabaseException was killed, one should use DomException now

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
File tests/html/shadow_dom_layout_test.dart (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
tests/html/shadow_dom_layout_test.dart:23: var sRoot =
div.webkitCreateShadowRoot();
no ShadowRoot constructor anymore.

[Siggi Cherem (dart-lang), 2012-12-21 17:03:14]

lgtm

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
File tests/html/shadow_dom_layout_test.dart (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
tests/html/shadow_dom_layout_test.dart:23: var sRoot =
div.webkitCreateShadowRoot();
On 2012/12/21 15:38:12, antonm wrote:
> no ShadowRoot constructor anymore.

:( - is this a change from webkit's IDLs?

[blois, 2012-12-21 17:20:14]

lgtm

[Emily Fortuna, 2012-12-21 19:05:15]

lgtm with suggestoin

https://codereview.chromium.org/11664009/diff/1/tests/html/indexeddb_4_test.dart
File tests/html/indexeddb_4_test.dart (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/indexeddb_4_test.d...
tests/html/indexeddb_4_test.dart:25: on DomException catch(e) { }          //
Firefox
change the comment here to Firefox and Chrome then

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
File tests/html/shadow_dom_layout_test.dart (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
tests/html/shadow_dom_layout_test.dart:23: var sRoot =
div.webkitCreateShadowRoot();
On 2012/12/21 17:03:15, Siggi Cherem (dart-lang) wrote:
> On 2012/12/21 15:38:12, antonm wrote:
> > no ShadowRoot constructor anymore.
> 
> :( - is this a change from webkit's IDLs?

Is this something we can/should fix on our end? If so I can open a bug.

[Jennifer Messerly, 2012-12-21 21:05:22]

lgtm

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
File tests/html/shadow_dom_layout_test.dart (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
tests/html/shadow_dom_layout_test.dart:23: var sRoot =
div.webkitCreateShadowRoot();
On 2012/12/21 19:05:15, Emily Fortuna wrote:
> On 2012/12/21 17:03:15, Siggi Cherem (dart-lang) wrote:
> > On 2012/12/21 15:38:12, antonm wrote:
> > > no ShadowRoot constructor anymore.
> > 
> > :( - is this a change from webkit's IDLs?

yes.

> 
> Is this something we can/should fix on our end? If so I can open a bug.

I don't think we should change this :). The new design was chosen intentionally
based on feedback to the Shadow DOM spec.

The old ShadowRoot constructor was strange for a bunch of reasons, among them
that it had a side effect on the host node. The new way of constructing a shadow
root makes a lot more sense. IMO.

[Jennifer Messerly, 2012-12-21 21:11:40]

On 2012/12/21 21:05:22, John Messerly wrote:
> lgtm
> 
>
https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
> File tests/html/shadow_dom_layout_test.dart (right):
> 
>
https://codereview.chromium.org/11664009/diff/1/tests/html/shadow_dom_layout_...
> tests/html/shadow_dom_layout_test.dart:23: var sRoot =
> div.webkitCreateShadowRoot();
> On 2012/12/21 19:05:15, Emily Fortuna wrote:
> > On 2012/12/21 17:03:15, Siggi Cherem (dart-lang) wrote:
> > > On 2012/12/21 15:38:12, antonm wrote:
> > > > no ShadowRoot constructor anymore.
> > > 
> > > :( - is this a change from webkit's IDLs?
> 
> yes.
> 
> > 
> > Is this something we can/should fix on our end? If so I can open a bug.
> 
> I don't think we should change this :). The new design was chosen
intentionally
> based on feedback to the Shadow DOM spec.
> 
> The old ShadowRoot constructor was strange for a bunch of reasons, among them
> that it had a side effect on the host node. The new way of constructing a
shadow
> root makes a lot more sense. IMO.

ah, I found the public discussion link:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=19562

[antonm, 2012-12-24 08:16:17]

Many thanks to everyone, rerunning tests and submitting

https://codereview.chromium.org/11664009/diff/1/tests/html/indexeddb_4_test.dart
File tests/html/indexeddb_4_test.dart (right):

https://codereview.chromium.org/11664009/diff/1/tests/html/indexeddb_4_test.d...
tests/html/indexeddb_4_test.dart:25: on DomException catch(e) { }          //
Firefox
On 2012/12/21 19:05:15, Emily Fortuna wrote:
> change the comment here to Firefox and Chrome then 

Done.